Re: FIX: today's ipfilter "mutex not locked" panic

From: Max Laier <max_at_love2party.net>
Date: Sat, 26 Jun 2004 01:12:44 +0200
On Thursday 24 June 2004 21:26, Giorgos Keramidas wrote:
> FWIW,
>
> I've locally fixed the panics that some people mentioned today for
> ipfilter with the following minor diff.  Now I can enable ipfilter
> at boot time and still boot without panics.
>
> --- patch begins ---
> Index: sys/contrib/ipfilter/netinet/fil.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/contrib/ipfilter/netinet/fil.c,v
> retrieving revision 1.38
> diff -u -r1.38 fil.c
> --- sys/contrib/ipfilter/netinet/fil.c	21 Jun 2004 22:46:35 -0000	1.38
> +++ sys/contrib/ipfilter/netinet/fil.c	24 Jun 2004 19:17:33 -0000
> _at__at_ -2155,9 +2155,6 _at__at_
>  		ip_natsync(ifp);
>  		ip_statesync(ifp);
>  	}
> -#  if defined(__FreeBSD_version) && (__FreeBSD_version >= 500043)
> -	IFNET_RUNLOCK();
> -#  endif
>  	ip_natsync((struct ifnet *)-1);
>  #  if defined(__FreeBSD_version) && (__FreeBSD_version >= 500043)
>  	IFNET_RUNLOCK();
> --- patch ends ---

The patch is right, looks like merge mess w/ rev. 1.33 to me. Darren (CC'ed) 
can you commit this?

-- 
Best regards,				| mlaier_at_freebsd.org
Max Laier				| ICQ #67774661
http://pf4freebsd.love2party.net/	| mlaier_at_EFnet







Received on Fri Jun 25 2004 - 21:16:00 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:59 UTC