Re: jail getfsstat patches.

On Fri, 25 Jun 2004, Julian Elischer wrote:

Hi,

[somewhat early and not realy awake but will be away the next hours
so here is some input]

> There are patches around to make 'df' and 'mount'
> show pretty much the exact right thing from a jail.

> I propose to commit these.

*yippie* I know a lot of people that will be happy :-)))


>     http://sources.zabbadoz.net/freebsd/jail.html
> for 5.x
>
> with possible small changes..

there are currently one to two minor bugs I have found while testing
this on 5.2.1-p8 on the version that is available; I have a newer
version here internally with one of the problems fixed.
No problem is too serious so anything would crash or panic. The
version has been workin on production systems since releasing now.

The first one is that one of the '/' was misplaced by a copy and paste
error and you would see s.th. like
/dev/ad0s2f   1972750   123014  1691916     7%
instead of
/dev/ad0s2f   1972750   123014  1691916     7%    /

The other is that if you have two jails at
/jail-abc
and
/jail-abcdefg

you will see something like

/dev/ad0s2f   1972750   123014  1691916     7%    defg

in /jail-abc; I think this problem might exist in more of the versions
I had seen. I am about to fix this but I will be away this weekend.
I might find the time on sunday eve.


For a FreebSD4-Version: I do not have a patch for that but there
have been other PRs (at least one from Oliver Fromme, PR47586)
and there has been a private patch from Chrisitian Kratzer (but
still w/o any sysctl).
An older version of my patch should be more easy to MFC (had
been done before the statfs changes) if you want that.


> Does anyone violently object to these?

not me; but -current has that sysctl people get pointed to and all the
related PRs got either ignored and closed for months now - so the
question would be: do other comitters welcome this ?
As said; I know a lot of people who would really like it...

-- 
Greetings

Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT