Re: Mozilla problems on current -- fix

From: Peter Schultz <pmes_at_bis.midco.net>
Date: Mon, 01 Mar 2004 16:07:00 -0600
Danny J. Zerkel wrote:
> Looks like John's sys/kern/kern_thread.c 1.171 broke Mozilla (and
> threading in general).  He appears to have left out a test that
> the sleeping thread is interruptable in one spot:
> 
> --- kern_thread.c.orig  Mon Mar  1 15:08:01 2004
> +++ kern_thread.c       Mon Mar  1 14:26:30 2004
> _at__at_ -646,7 +646,8 _at__at_
>                 } else if (TD_ON_SLEEPQ(td2) &&
>                            ((td2->td_wchan == &kg->kg_completed) ||
>                             (td2->td_wchan == &p->p_siglist &&
> -                            (ku->ku_mflags & KMF_WAITSIGEVENT)))) {
> +                            (ku->ku_mflags & KMF_WAITSIGEVENT))) &&
> +                             (td2->td_flags & TDF_SINTR)) {
>                         sleepq_abort(td2);
>                 } else {
>                         ku->ku_flags |= KUF_DOUPCALL;
> 
> This change fixes my Mozilla hangs and other panics on current.
>

Do you have ULE and ADAPTIVE_MUTEXES in your kernel conf?

Thanks,
Pete...
Received on Mon Mar 01 2004 - 13:07:02 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:45 UTC