Re: cross make buildworld failure

On Sun, Mar 14, 2004 at 04:32:03PM -0800, David O'Brien wrote:
> On Fri, Mar 05, 2004 at 05:51:13PM +0200, Ruslan Ermilov wrote:
> > > ===> gnu/usr.bin/binutils/gasp
> ...
> > > /usr/include/regex.h:56: syntax error before `regoff_t'
> > > gasp+%FIXED.c: In function `chew_flonum':
> > > gasp+%FIXED.c:553: structure has no member named `rm_eo'
> > > gasp+%FIXED.c:553: structure has no member named `rm_so'
> > > gasp+%FIXED.c:554: structure has no member named `rm_eo'
> > > gasp+%FIXED.c:554: structure has no member named `rm_so'
> > > gasp+%FIXED.c:558: structure has no member named `rm_eo'
> > > 
> > Thanks for the report, we're working on resolving this.  The
> > workaround (if you need this quickly) is to remove
> > src/contrib/binutils/include/getopt.h, and revert the following
> 
> What does getopt.h have to do with a regex API issue??
> 
By not quoting all of my reply, you've lost some useful context:

On Fri, Mar 05, 2004 at 05:51:13PM +0200, Ruslan Ermilov wrote:
[...]
> Thanks for the report, we're working on resolving this.  The
> workaround (if you need this quickly) is to remove
> src/contrib/binutils/include/getopt.h, and revert the following
> revisions:
> 
> src/gnu/usr.bin/binutils/Makefile.inc0,v 1.34
> src/gnu/usr.bin/binutils/gasp/Makefile,v 1.16

The above two revisions were aimed at picking up the "correct"
version of getopt.h, and they have polluted the makefiles with
-I${DESTDIR}/usr/include/gnu.  As gasp(1) is also a cross tool,
the side effect of this change was that it started using the
/usr/include/regex.h header instead of the proper bootstrappable
one from ${WORLDTMP}/legacy/usr/include.  The former requires
including of <sys/types.h> in RELENG_4, as documented in the
regex(3) manpage, the latter handles this bootstrapping issue
(see src/tools/build/regex.h).

The solution was to back out those revisions, and remove the
version of getopt.h from contrib/bintutils.  (Soon after I've
realized that it doesn't harm at all to use getopt.h and
friends from contrib/binutils.)


Cheers,
-- 
Ruslan Ermilov
FreeBSD committer
ru_at_FreeBSD.org