Re: sio: lots of silo overflows on Asus K8V with Moxa Smartio C104H/PCI

From: Bruce Evans <bde_at_zeta.org.au>
Date: Sun, 9 May 2004 22:06:06 +1000 (EST)
On Sun, 9 May 2004, Timo Geusch wrote:

> On Tue, May 04, 2004 at 02:17:16PM +1000, Bruce Evans wrote:
> > BTW, there are about 34 broken drivers that use
> > BUS_SETUP_INTR(device_get_parent(...), ...) instead of bus_setup_interrupt().
> > This just evades printing of the FAST/GIANT-LOCKED/MPSAFE boot message.
> > BUS_SETUP_INTR() seems to be needed in only 10 files.
>
> Is there a fairly simple way to indentify where BUS_SETUP_INTR is needed?
> I might have a couple of hours to spare to look into this...

I just grepped for "BUS_SETUP_INTR.*device_get_parent" .  There is no
reason to use BUS_SETUP_INTR() when bus_setup_intr() can do the same
thing (except for printing the message.  It might not be correct that
bus_setup_intr() is the only place that prints the FAST/GIANT-LOCKED/MPSAFE
message, but printing it in every layer would be wrong.

Bruce
Received on Sun May 09 2004 - 03:06:13 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:53 UTC