Re: new arp code snapshot for review...

On Sun, 16 May 2004, Doug Rabson wrote:

DR>On Sunday 25 April 2004 17:49, Luigi Rizzo wrote:
DR>> Here is a snapshot of the new arp code that i have been working on
DR>> lately, based a on Andre's ideas. (I say 'ARP' for brevity, what i
DR>> mean is the layer3-to-layer2 address translation code -- arp, aarp,
DR>> nd6 all fit in the category).
DR>
DR>Sorry for the delay but I've only just had reason to look at the arp 
DR>code since I've recently been working on an implementation of rfc2734 
DR>IP over firewire. In your patch, you assume that the size of the 
DR>link-level address is always six bytes. This assumption is not valid - 
DR>from the looks of the existing arp code, people went to great lengths 
DR>to avoid making this assumption throughout the networking code.
DR>
DR>For IP over firewire, the link-level address is sixteen bytes. Other 
DR>link types have various sizes. You must use ifp->if_addrlen in the 
DR>generic code to cope with this correctly.

Sorry to step in that late, but I'm currently moving jobs.

I had the same comment. The ARP table could be used for the various IP
over ATM address mappings. In that case it needs to support 20 byte NSAPs
with and optional subaddress (also 20 byte) and variable size E.164 
addresses. 

harti