Re: wmnet-1.2 broken by if_poll_slowq

On Thu, May 20, 2004 at 10:55:35PM -0700, Kris Kennaway wrote:
> On Tue, May 04, 2004 at 01:35:55PM -0700, Luigi Rizzo wrote:
> > On Tue, May 04, 2004 at 01:03:16PM -0700, Kris Kennaway wrote:
> > > Can whoever made this change please develop a patch for the port?
> > 
> > looking at the code, i would just compile it with -DNDEBUG
> > Alternatively, this one should work (beware of whitespace,
> > i cut&pasted...)
> 
> Is this patch also appropriate for 4.x?

yes . There was no point in zeroing those fields, anyways.
The program does not use them.

	cheers
	luigi

> Kris
> 
> > 
> > 	cheers
> > 	luigi
> > 
> > luigi# diff -ubwr if.c.orig if.c
> > --- if.c.orig   Tue May  4 22:37:31 2004
> > +++ if.c        Tue May  4 22:39:56 2004
> > _at__at_ -186,7 +186,6 _at__at_
> >  #endif
> >                         d.if_bpf = 0;
> >                         d.if_linkmib = 0;
> > -                       d.if_poll_slowq = 0;
> >  #endif
> >                         c = a;
> >                         return &d;
> > 
> > > Kris
> > > 
> > > ----- Forwarded message from User Ports-i386 <ports-i386_at_FreeBSD.org> -----
> > > 
> > > X-Original-To: kkenn_at_localhost
> > > Delivered-To: kkenn_at_localhost.obsecurity.org
> > > Delivered-To: kris_at_freebsd.org
> > > Date: Tue, 4 May 2004 16:57:00 GMT
> > > From: User Ports-i386 <ports-i386_at_FreeBSD.org>
> > > To: kris_at_FreeBSD.org
> > > Subject: wmnet-1.2 failed on i386 5
> > > X-UIDL: \mP!!4(<"!mej!!H^p"!
> > > X-Bogosity: No, tests=bogofilter, spamicity=0.000000, version=0.17.5
> > > 
> > > building wmnet-1.2 on gohan11
> > > in directory /x/tmp/5/chroot/12473
> > > maintained by: ports_at_FreeBSD.org
> > > build started at Tue May  4 16:55:21 GMT 2004
> > > add_pkg
> > > ================================================================
> > > ====================<phase 1: make checksum>====================
> > > ===>  Vulnerability check disabled
> > > >> wmnet-1.2.tar.gz doesn't seem to exist in /tmp/distfiles/.
> > > >> Attempting to fetch from ftp://ftp-master.freebsd.org/pub/FreeBSD/ports/distfiles//.
> > > wmnet-1.2.tar.gz                                        19 kB 1011 kBps
> > > >> Checksum OK for wmnet-1.2.tar.gz.
> > > ================================================================
> > > ====================<phase 2: make extract>====================
> > > add_pkg
> > > ===>  Vulnerability check disabled
> > > ===>  Extracting for wmnet-1.2
> > > >> Checksum OK for wmnet-1.2.tar.gz.
> > > ================================================================
> > > ====================<phase 3: make patch>====================
> > > add_pkg
> > > ===>  Patching for wmnet-1.2
> > > ===>  Applying FreeBSD patches for wmnet-1.2
> > > ================================================================
> > > ====================<phase 4: make build>====================
> > > add_pkg XFree86-libraries-4.3.0_7.tbz expat-1.95.7.tbz fontconfig-2.2.2,1.tbz freetype2-2.1.7_3.tbz imake-4.3.0_2.tbz perl-5.8.2_5.tbz pkgconfig-0.15.0_1.tbz
> > > adding dependencies
> > > pkg_add XFree86-libraries-4.3.0_7.tbz
> > > Running fc-cache to build fontconfig cache...
> > > fc-cache: "/usr/X11R6/lib/X11/fonts": caching, 0 fonts, 13 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/100dpi": caching, 0 fonts, 0 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/75dpi": caching, 0 fonts, 0 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/CID": caching, 0 fonts, 0 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/PEX": caching, 0 fonts, 0 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/Speedo": caching, 0 fonts, 0 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/TTF": caching, 0 fonts, 0 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/Type1": caching, 0 fonts, 0 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/cyrillic": caching, 0 fonts, 0 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/encodings": caching, 0 fonts, 1 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/encodings/large": caching, 0 fonts, 0 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/latin2": caching, 0 fonts, 2 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/latin2/100dpi": caching, 0 fonts, 0 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/latin2/75dpi": caching, 0 fonts, 0 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/local": caching, 0 fonts, 0 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/misc": caching, 0 fonts, 0 dirs
> > > fc-cache: "/usr/X11R6/lib/X11/fonts/util": caching, 0 fonts, 0 dirs
> > > fc-cache: "/root/.fonts": skipping, no such directory
> > > fc-cache: succeeded
> > > pkg_add expat-1.95.7.tbz
> > > skipping expat-1.95.7, already added
> > > pkg_add fontconfig-2.2.2,1.tbz
> > > skipping fontconfig-2.2.2,1, already added
> > > pkg_add freetype2-2.1.7_3.tbz
> > > skipping freetype2-2.1.7_3, already added
> > > pkg_add imake-4.3.0_2.tbz
> > > skipping imake-4.3.0_2, already added
> > > pkg_add perl-5.8.2_5.tbz
> > > skipping perl-5.8.2_5, already added
> > > pkg_add pkgconfig-0.15.0_1.tbz
> > > skipping pkgconfig-0.15.0_1, already added
> > > ===>   wmnet-1.2 depends on shared library: X11.6 - found
> > > ===>  Configuring for wmnet-1.2
> > > ===>  Building for wmnet-1.2
> > > cc -c -O -pipe   -g -Wall -I/usr/X11R6/include main.c -o main.o
> > > cc -c -O -pipe   -g -Wall -I/usr/X11R6/include if.c -o if.o
> > > if.c: In function `dereference':
> > > if.c:201: error: structure has no member named `if_poll_slowq'
> > > *** Error code 1
> > > 
> > > Stop in /tmp/a/ports/net/wmnet/work/wmnet-1.2.
> > > *** Error code 1
> > > 
> > > Stop in /a/ports/net/wmnet.
> > > ================================================================
> > > build ended at Tue May  4 16:56:57 GMT 2004
> > > 
> > > 
> > > ----- End forwarded message -----
> > 
> > 
> >