Re: Small patch for if_ndis_pccard.c

On Wed, Mar 10, 2004 at 11:37:02AM +0000, Bob Bishop wrote:
> Had a go with this 3Com 3CRSHPW196. Had to apply the following patch to 
> work around a difference of opinion between the .inf file and the card CIS 
> about the use of underscores:
> 
> --- if_ndis_pccard.c.orig	Wed Mar 10 10:27:37 2004
> +++ if_ndis_pccard.c	Wed Mar 10 11:10:54 2004
> _at__at_ -134,7 +134,9 _at__at_
>  	int			i;
> 
>  	for (i = 0; i < len; i++) {
> -		if (toupper(s1[i]) != toupper(s2[i]))
> +		if (toupper(s1[i]) != toupper(s2[i])
> +		    && !(s1[i] == ' ' && s2[i] == '_')
> +		    && !(s1[i] == '_' && s2[i] == ' '))
>  			return(0);
>  	}
> 
> I suppose you might prefer to fix this sort of thing in ndiscvt.

FWIW this patch works for me. Well, where "works" means it now detects
the card :-)

> Anyway, with the patch the card attaches etc but we get a panic (as kind of 
> expected) when trying to bring the interface up with ifconfig.
> 
> FWIW, log:
> 
> ndis0: <3Com 3CRSHPW_96 Wireless LAN PC Card> at port 0x100-0x11f irq 11 
> function 0 config 1 on pccard0
> can't re-use a leaf (Rate)!
> can't re-use a leaf (RTS_Threshold)!
> can't re-use a leaf (Frag_Threshold)!
> can't re-use a leaf (PreambleType)!
> can't re-use a leaf (Channel)!
> can't re-use a leaf (Operating_Mode)!
> can't re-use a leaf (ESSID)!
> can't re-use a leaf (WEP_KEY_INDEX)!
> can't re-use a leaf (EncryptionLevel)!
> can't re-use a leaf (WEP_KEY_1)!
> can't re-use a leaf (WEP_KEY_2)!
> can't re-use a leaf (WEP_KEY_3)!
> can't re-use a leaf (WEP_KEY_4)!
> can't re-use a leaf (WEP_Mode)!
> can't re-use a leaf (AuthenticationType)!
> can't re-use a leaf (PowerMgmtMode)!
> can't re-use a leaf (BasicRates)!
> can't re-use a leaf (BeaconPeriod)!
> ndis0: NDIS API version: 5.1
> ndis0: 802.11 address: 00:04:75:9a:46:20
> ndis0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps
> 
> (Not so easy to catch the panic, this ThinkPad doesn't have a serial port.)

And likewise, exactly the same output and panic. I'm using -CURRENT as
of today. I'm happy to try and provide more information, but like Bob
I'm also using a thinkpad.

Cheers,
Tim.

-- 
Tim Bishop
http://www.bishnet.net/tim
PGP Key: 0x5AE7D984