Re: if_sk patch to get more info from people with problems

From: John-Mark Gurney <gurney_j_at_resnet.uoregon.edu>
Date: Tue, 2 Nov 2004 11:08:51 -0800
Peter Edwards wrote this message on Tue, Nov 02, 2004 at 17:56 +0000:
> A (very) quick look at the source reveals that buffers are allocated
> via  sk_rxeof()->sk_newbuf()->sk_jalloc() in the interrupt receive
> function, with the softc lock held in sk_rxeof().
> 
> They're freed by the mbuf system via a call to sk_jfree(), but that
> doesn't hold the SK_LOCK. Is this possibly the source of the
> corruption problems? What am I missing?
> This compiles, anyway :-)

Well, try the attached patch (it also includes my changes from a previous
diff) that will see what happens...  Make sure you have your kernel
compiled with WITNESS and INVARIANTS...  If you hit one of these
asserts, make sure you post the back trace...

Thanks for the testing..

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."

Received on Tue Nov 02 2004 - 18:08:54 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:20 UTC