Re: [TEST] make -j patch [take 2]

From: Alexander Leidinger <Alexander_at_Leidinger.net>
Date: Mon, 15 Nov 2004 12:29:51 +0100
Zitat von Harti Brandt <harti_at_freebsd.org>:

[knu CCed because he should know how portupgrade operates :-)]

> Unless you reset MAKEFLAGS along the call path to the portupgrade's make
> they'll see the -j, because the top-level make will stuff the -j into
> MAKEFLAGS and that is probably inherited through portupgrade.

I don't know how ruby handles exec()ing of external programs, but unless
it inherits the environment by default, portupgrade doesn't seems to
inherit MAKEFLAGS ("grep MAKEFLAGS /usr/local/lib/ruby/site_ruby/1.8/*
/usr/local/sbin/port*" shows no hits).

So if portupgrade inherits MAKEFLAGS somehow, phk's patch shouldn't
cause unexpected harm in this szenario, if portupgrade doesn't inherit
MAKEFLAGS, his patch violates POLA in this case.

Bye,
Alexander.

-- 
http://www.Leidinger.net/     Alexander _at_ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org/        netchild _at_ FreeBSD.org  : PGP ID = 72077137
Received on Mon Nov 15 2004 - 10:29:48 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:22 UTC