Re: mem leak in mii ?

From: Bjoern A. Zeeb <bzeeb-lists_at_lists.zabbadoz.net>
Date: Mon, 22 Nov 2004 22:08:24 +0000 (UTC)
On Mon, 22 Nov 2004, John Baldwin wrote:

> On Friday 19 November 2004 06:49 pm, Bjoern A. Zeeb wrote:
> > Hi,
> >
> > in sys/dev/mii/mii.c there are two calls to malloc for ivars;
> > see for example mii_phy_probe:
...
> > Where is the free for this malloc ? I cannot find it.
> >
> > analogous: miibus_probe ?
>
> It's a leak.  It should be free'd when the miibus device is destroyed.  Here's
> a possible fix:

this does only catch about 75% of what may happen I think.

mii isn't very error checking at all and I have run into even more
problems while remotely debugging other problems with someone.

I am currently working on a hopefully more complete fix (there are
two leaks actually).

-- 
Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT
Received on Mon Nov 22 2004 - 21:10:10 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:23 UTC