Re: patch: udma5 support for Intel 82801FB ICH6 Ultra ATA Controller

Florian Le Goff wrote:
> Hi,
> 
> I've got an ASUS P5GD1 [1] Motherboard, with a 915P chipset and a
> ICH6R [2] southbridge.
> 
> Since the UDMA controller was recognized as an "GENERIC ATA
> controller", I was stuck in UDMA33 mode for my Seagate Ultra ATA/100
> IDE hard drive, and I wasn't able to change the settings using
> "atacontrol mode". Since there is already a great list of Intel
> supported chipsets in src/sys/dev/ata/ata-chipset.c, I've added the
> references of the chip in ata-chipset.c and ata-pci.h, on a fresh
> cvsuped 6.0-CURRENT.
> 
> Please, someone could review it ? My first patch :/

You could just add a define for the other one as well (se attached 
patch) and have the SATA ports usable as well.

Now as wonderfull as this might be, we want to support the ACHI part of 
the ICH6 for SATA support. That is a totally different animal much like 
the Promise and Marvell controllers, and is in the works here but will 
not be ready for 5.3 is the current timelines holds.

Actually I should commit that to -current since it at least allows the 
ICH6 to be used in legacy mode..


-- 

-Søren


Index: ata-chipset.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/ata-chipset.c,v
retrieving revision 1.91
diff -u -r1.91 ata-chipset.c
--- ata-chipset.c	6 Oct 2004 19:46:07 -0000	1.91
+++ ata-chipset.c	9 Oct 2004 16:16:20 -0000
_at__at_ -833,6 +833,9 _at__at_
      { ATA_I6300ESB,   0, 0, 0x00, ATA_UDMA5, "Intel 6300ESB" },
      { ATA_I6300ESB_S1,0, 0, 0x00, ATA_SA150, "Intel 6300ESB" },
      { ATA_I6300ESB_R1,0, 0, 0x00, ATA_SA150, "Intel 6300ESB" },
+     { ATA_I82801FB,   0, 0, 0x00, ATA_UDMA5, "Intel ICH6" },
+     { ATA_I82801FB_S1,0, 0, 0x00, ATA_SA150, "Intel ICH6" },
+     { ATA_I82801FB_R1,0, 0, 0x00, ATA_SA150, "Intel ICH6" },
      { 0, 0, 0, 0, 0, 0}};
     char buffer[64]; 
 
Index: ata-pci.h
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/ata-pci.h,v
retrieving revision 1.34
diff -u -r1.34 ata-pci.h
--- ata-pci.h	6 Oct 2004 19:46:08 -0000	1.34
+++ ata-pci.h	9 Oct 2004 16:21:28 -0000
_at__at_ -121,6 +121,9 _at__at_
 #define ATA_I6300ESB		0x25a28086
 #define ATA_I6300ESB_S1		0x25a38086
 #define ATA_I6300ESB_R1		0x25b08086
+#define ATA_I82801FB		0x266f8086
+#define ATA_I82801FB_S1		0x26518086
+#define ATA_I82801FB_R1		0x26528086
 
 #define ATA_NATIONAL_ID		0x100b
 #define ATA_SC1100		0x0502100b