Robert, just wanted to drop a quick update - after I've applied your patch, it's been up for a couple of days now ... we don't have that bad traffic now, so it's hard to judge did it really help it or not, but at least it looks like it didn't hurt ;) would you drop me a note after this patch will be submitted to releng 5.3 branch? thank you. On Mon, 18 Oct 2004 18:24:06 -0400 (EDT), Robert Watson <rwatson_at_freebsd.org> wrote: > > I've merged a likely fix to the problem to HEAD as of a minute or two ago, > which broadens the scope of the accept mutex to reduce the opportunity for > races (it both expands the coverage to some additional reference > operations, and also avoids dropping a lock to reorder). With this change > in place, I'm no longer able to easily reproduce the problem -- I've had a > couple of SMP boxes running for an hour or two trying without success. > Previously I had reproduction time with just the right traffic down to a > second or two. I'll merge the fix to RELENG_5 shortly for merge to > RELENG_5_3 before 5.3 goes out the door. Obviously, any help in getting > testing exposure for this change, as it comes very late in the release > cycle, would be most welcome. A copy of the patch can be found at: > > http://www.watson.org/~robert/freebsd/netperf/20041018-sofree-race-fix.diff > > A complete description can be found in the commit message. Thanks to > everyone who has helped diagnosis and fix this! Hopefully we've got the > right fix now, although obviously as the next few days of testing play > out, we'll see. -- VladReceived on Thu Oct 21 2004 - 00:02:39 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:18 UTC