Re: broken APM on IBM-T30 with 6.0-CURRENT

Jake Khuon wrote:
> ### On Thu, 28 Oct 2004 17:38:52 -0700, Bruce M Simpson <bms_at_spc.org>
> ### casually decided to expound upon Jake Khuon <khuon_at_NEEBU.Net> the
> ### following thoughts about "Re: broken APM on IBM-T30 with 6.0-CURRENT":
> 
> BMS> On Thu, Oct 28, 2004 at 05:33:03PM -0700, Jake Khuon wrote:
> BMS> > That patch worked perfectly. I had to do a little hand-patching of one of
> BMS> > the hunks that got rejected though.  Any thoughts on if this will get
> BMS> > merged?  Thanks.
> BMS> 
> BMS> Please send me these patches so I can look at them...
> 
> After applying the patch, I did a backdiff.  This is against:
> 
> /src/sys/dev/ata/ata-all.c,v 1.233 2004/10/19 20:13:38
> ***************
> *** 346,356 ****
> --- 347,359 ----
>   	if (ch->state == ATA_IDLE) {
>   	    ch->state = ATA_ACTIVE;
>   	    mtx_unlock(&ch->state_mtx);
> + 	    goto out;
>   	    break;
>   	}
>   	mtx_unlock(&ch->state_mtx);
>   	tsleep(ch, PRIBIO, "atasusp", hz/10);
>       }
> + out:    
>       ch->locking(ch, ATA_LF_UNLOCK);
>       return 0;
>   }

That part cant be needed right ?

As for the rest, it works around the problem that tsleep doesn't seem to 
work on the resume path under APM. Now that is all nice and that, but 
I'd like to get the real problem fixed: why doesn't tsleep work there ?

-- 

-Søren