Re: Panic in propagate_priority() [5.3-BETA2]

From: Patrick Guelat <pg_at_imp.ch>
Date: Thu, 2 Sep 2004 21:20:23 +0000 (UTC)
On Thu, 2 Sep 2004, Robert Watson wrote:

>> exclusive sleep mutex rip r=1 (0xc079e70c) locked _at_ /usr/src53/sys/netinet6/raw_ip.c:255
>
> Ah, indeed, there's an incorrect "lock" instead of "unlock" there.  Could
> you try the attached patch:

Thanks. Your patch works like a dream. I looked a that line a dozen
times and didn't realize it was a lock instead of an unlock ;-)
I was just wondering why you're using the same lock in IPv4 and IPv6
and if this probably may cause problems in ipv6 over ipv4 situations.

Tested on RELENG_5

-Patrick

>
> Index: raw_ip6.c
> ===================================================================
> RCS file: /data/fbsd-cvs/ncvs/src/sys/netinet6/raw_ip6.c,v
> retrieving revision 1.45
> diff -u -r1.45 raw_ip6.c
> --- raw_ip6.c	12 Aug 2004 18:31:36 -0000	1.45
> +++ raw_ip6.c	2 Sep 2004 12:55:19 -0000
> _at__at_ -252,7 +252,7 _at__at_
> 		}
> 		ip6stat.ip6s_delivered--;
> 	}
> -	INP_INFO_RLOCK(&ripcbinfo);
> +	INP_INFO_RUNLOCK(&ripcbinfo);
> 	return IPPROTO_DONE;
> }
--
Patrick Guélat, ImproWare AG Network Services, CH-4133 Pratteln
Mail: Patrick.Guelat_at_imp.ch - Phone: +41 61 826 93 00 (ext: 13)
Received on Thu Sep 02 2004 - 17:23:53 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:10 UTC