Re: [PATCH] poll() hang with X apps

On Sun, 5 Sep 2004, Maxim Maximov wrote:

> > Yeah, I had a good idea about what the problem might be, but I couldn't
> > reproduce it here.  Happily, Doug could and was willing to spend a lot of
> > time with the debugger to track stuff down.  Turns out it may have been a
> > potential race I tagged when I was originally reviewing that element of
> > socket locking, but hadn't yet had a chance to revisit.  If the patch
> > fixes it, wonderful!  If not, there are one or two other things in the
> > polling/select code that could use review.  Assuming this patch does fix
> > the problem for you (it did for Doug), I'll get it merged into HEAD
> > tomorrow, and RELENG_5 a few days later.
> > 
> > Thanks for your bug report, and we'll see how it goes :-).
> 
> It goes very well. Easily reproducible xscreensaver hacks hangs
> described by Doug are gone for me too. I believe the patch also solves
> my dockapp problems. I haven't seen any wmdockapps hangs yet, but they
> are harder to reproduce, so only time will tell. 
> 
> I guess this patch should be merged anyway. At least for xscreensaver
> related hangs :) 

Wonderful.  I've merged this to HEAD and put it on the RELENG_5 MFC path
to merge in a couple of days.  Thanks! 

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert_at_fledge.watson.org      Principal Research Scientist, McAfee Research