Possible bug in softclock()

From: Matthew Dillon <dillon_at_apollo.backplane.com>
Date: Mon, 13 Sep 2004 22:09:40 -0700 (PDT)
    In softclock(), should this line:

	c->c_flags = (c->c_flags & ~CALLOUT_PENDING);

    be:

	c->c_flags = (c->c_flags & ~(CALLOUT_PENDING | CALLOUT_MPSAFE));

    ?

    Otherwise routines which call callout_reset() to reset the callout
    will always clear the CALLOUT_MPSAFE flag.  This won't hurt things,
    but it will make them more inefficient.

					-Matt
					Matthew Dillon 
					<dillon_at_backplane.com>
Received on Tue Sep 14 2004 - 03:09:43 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:11 UTC