Re: rcorder(8) dumps core

On 2004-09-14 17:52, Lukas Ertl <le_at_freebsd.org> wrote:
> Hi,
> today I noticed a problem with rcorder on a very recent -CURRENT:

The core dump is triggered by the circular deps introduced by a recent
s/ntpdate/ntpd/ in rc.d/rpcbind (see my reply to the commit message).
>From a very quick first check it seems that circular dependencies
somehow mess up the memory management of rcorder and it bombs while
trying to free() the same pointer.

The rest of the warnings printed by rcorder (missing or plainly wrong
dependencies) can be fixed by this patch (which I haven't sent to
freebsd-rc for review yet, but here it is):

%%%
Index: ike
===================================================================
RCS file: /home/ncvs/src/etc/rc.d/ike,v
retrieving revision 1.2
diff -u -r1.2 ike
--- ike	8 Mar 2004 12:25:05 -0000	1.2
+++ ike	14 Sep 2004 10:10:15 -0000
_at__at_ -4,7 +4,7 _at__at_
 #
 
 # PROVIDE: ike
-# REQUIRE: root beforenetlkm mountcritlocal
+# REQUIRE: root mountcritlocal
 # BEFORE:  DAEMON
 # KEYWORD: FreeBSD nojail
 
Index: nsswitch
===================================================================
RCS file: /home/ncvs/src/etc/rc.d/nsswitch,v
retrieving revision 1.3
diff -u -r1.3 nsswitch
--- nsswitch	21 Jun 2004 19:38:58 -0000	1.3
+++ nsswitch	14 Sep 2004 10:09:46 -0000
_at__at_ -28,7 +28,7 _at__at_
 
 # PROVIDE: nsswitch
 # REQUIRE: root
-# BEFORE:  network
+# BEFORE:  NETWORK
 # KEYWORD: FreeBSD
 
 . /etc/rc.subr
Index: pf
===================================================================
RCS file: /home/ncvs/src/etc/rc.d/pf,v
retrieving revision 1.3
diff -u -r1.3 pf
--- pf	23 Jun 2004 01:42:06 -0000	1.3
+++ pf	14 Sep 2004 10:08:31 -0000
_at__at_ -4,7 +4,7 _at__at_
 #
 
 # PROVIDE: pf
-# REQUIRE: root beforenetlkm mountcritlocal netif pflog
+# REQUIRE: root mountcritlocal netif pflog
 # BEFORE:  DAEMON LOGIN
 # KEYWORD: FreeBSD nojail
 
Index: pflog
===================================================================
RCS file: /home/ncvs/src/etc/rc.d/pflog,v
retrieving revision 1.2
diff -u -r1.2 pflog
--- pflog	31 Aug 2004 14:23:51 -0000	1.2
+++ pflog	14 Sep 2004 10:08:10 -0000
_at__at_ -4,7 +4,7 _at__at_
 #
 
 # PROVIDE: pflog
-# REQUIRE: root beforenetlkm mountcritlocal netif
+# REQUIRE: root mountcritlocal netif
 # BEFORE:  DAEMON LOGIN
 # KEYWORD: FreeBSD nojail
 
%%%