Re: rexecd break world

On Tue, Apr 05, 2005 at 10:23:29AM -0700, Steve Kargl wrote:
> On Tue, Apr 05, 2005 at 10:19:23AM -0700, Steve Kargl wrote:
> > ===> libexec/rexecd (all)
> > cc -O -pipe -march=opteron -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -c /usr/src/libexec/rexecd/rexecd.c
> > /usr/src/libexec/rexecd/rexecd.c: In function `doit':
> > /usr/src/libexec/rexecd/rexecd.c:206: warning: passing arg 4 of `xgetpwnam' from incompatible pointer type
> > *** Error code 1
> > 
> > Stop in /usr/src/libexec/rexecd.
> > *** Error code 1
> > 
> 
> Watch for cut-n-paste problems.
> 
> --- /tmp/rexecd.c       Tue Apr  5 10:21:37 2005
> +++ /usr/src/libexec/rexecd/rexecd.c    Tue Apr  5 10:20:30 2005
> _at__at_ -139,7 +139,7 _at__at_
>         char user[16], pass[16];
>         struct passwd *pwd, pwd_storage;
>         char *pwdbuf;
> -       int pwdbuflen;
> +       size_t pwdbuflen;
>         int fd, r, sd;
>         u_short port;
>         int pv[2], pid, cc, nfds;
> 

This patch works.

I suspect the at the 5.4 branch is now broken with this change.

-- 
Steve