Re: Locking fixes for dc(4): please test!

On Aug 10, 2005, at 1:56 PM, John Baldwin wrote:

> On 2005.08.04 12:55:05 -0400, John Baldwin wrote:
>
>> I have some fixes for the locking in the dc(4) driver, please test  
>> them
>> if you have some dc(4) hardware, thanks!
>>
>> http://www.FreeBSD.org/~jhb/patches/dc_locking.patch
>>
>
> I've updated the patch to use callout_init_mtx() and would  
> appreciate it if
> the folks who tested it earlier could retest it.  Also, can someone  
> with an
> Alpha please test this as I messed around with the SRM_MEDIA code  
> some in
> order to make the locking in dc_init_locked() sane and it needs  
> testing on an
> Alpha.

It doesn't build on alpha:

ds10% cd /sys/alpha/compile/DS10
ds10% make
cc -c -O -pipe -mcpu=ev6 -mieee -Wall -Wredundant-decls -Wnested- 
externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith - 
Winline -Wcast-qual  -fformat-extensions -std=c99 -g -nostdinc -I-  - 
I. -I../../.. -I../../../contrib/dev/acpica -I../../../contrib/altq - 
I../../../contrib/ipfilter -I../../../contrib/pf -I../../../contrib/ 
dev/ath -I../../../contrib/dev/ath/freebsd -I../../../contrib/ngatm - 
I../../../dev/twa -D_KERNEL -include opt_global.h -fno-common - 
finline-limit=15000 --param inline-unit-growth=100 --param large- 
function-growth=1000  -mno-fp-regs -ffixed-8 -Wa,-mev6 -ffreestanding  
-Werror  ../../../pci/if_dc.c
../../../pci/if_dc.c: In function `dc_init':
../../../pci/if_dc.c:3407: error: `ifp' undeclared (first use in this  
function)
../../../pci/if_dc.c:3407: error: (Each undeclared identifier is  
reported only once
../../../pci/if_dc.c:3407: error: for each function it appears in.)
../../../pci/if_dc.c:3407: error: `mii' undeclared (first use in this  
function)
*** Error code 1

...The SRM_MEDIA macro is probably only defined on alpha...

-- 
  Marcel Moolenaar         USPA: A-39004          marcel_at_xcllnt.net