Re: New libc malloc patch

On Dec 3, 2005, at 12:45 PM, Claus Guttesen wrote:

>> There's a new version of the patch available at:
>> http://www.canonware.com/~jasone/jemalloc/jemalloc_20051202b.diff
>
> When I do a make buildworld I get:
>
> cc -fpic -DPIC -O2 -fno-strict-aliasing -pipe -march=athlon64
> -I/usr/src/lib/libc/include -I/usr/src/lib/libc/../../include
> -I/usr/src/lib/libc/amd64 -D__DBINTERFACE_PRIVATE
> -I/usr/src/lib/libc/../../contrib/gdtoa -DINET6
> -I/usr/obj/usr/src/lib/libc -DPOSIX_MISTAKE -I/usr/src/lib/libc/locale
> -DBROKEN_DES -DPORTMAP -DDES_BUILTIN -I/usr/src/lib/libc/rpc -DYP
> -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -c
> /usr/src/lib/libc/stdlib/malloc.c -o malloc.So
> cc -O2 -fno-strict-aliasing -pipe -march=athlon64
> -I/usr/src/lib/libc/include -I/usr/src/lib/libc/../../include
> -I/usr/src/lib/libc/amd64 -D__DBINTERFACE_PRIVATE
> -I/usr/src/lib/libc/../../contrib/gdtoa -DINET6
> -I/usr/obj/usr/src/lib/libc -DPOSIX_MISTAKE -I/usr/src/lib/libc/locale
> -DBROKEN_DES -DPORTMAP -DDES_BUILTIN -I/usr/src/lib/libc/rpc -DYP
> -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -c
> /usr/src/lib/libc/stdlib/merge.c
> /usr/src/lib/libc/stdlib/malloc.c: In function `malloc_mutex_lock':
> /usr/src/lib/libc/stdlib/malloc.c:846: warning: cast from pointer to
> integer of different size
> /usr/src/lib/libc/stdlib/malloc.c:846: warning: cast from pointer to
> integer of different size
> /usr/src/lib/libc/stdlib/malloc.c:853: warning: cast from pointer to
> integer of different size
> /usr/src/lib/libc/stdlib/malloc.c: In function `malloc_mutex_unlock':
> /usr/src/lib/libc/stdlib/malloc.c:894: warning: cast from pointer to
> integer of different size
> *** Error code 1
> /usr/src/lib/libc/stdlib/malloc.c: In function `malloc_mutex_lock':
> /usr/src/lib/libc/stdlib/malloc.c:846: warning: cast from pointer to
> integer of different size
> /usr/src/lib/libc/stdlib/malloc.c:846: warning: cast from pointer to
> integer of different size
> /usr/src/lib/libc/stdlib/malloc.c:853: warning: cast from pointer to
> integer of different size
> /usr/src/lib/libc/stdlib/malloc.c: In function `malloc_mutex_unlock':
> /usr/src/lib/libc/stdlib/malloc.c:894: warning: cast from pointer to
> integer of different size
> *** Error code 1
> 2 errors
> *** Error code 2
> 1 error
> *** Error code 2
> 1 error
> *** Error code 2
> 1 error
> *** Error code 2
> 1 error
> *** Error code 2
> 1 error
> make -j 3 buildworld  763,54s user 150,98s system 173% cpu 8:48,62  
> total
>
> twin/usr/src#>uname -a
> FreeBSD twin.gnome.no 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Thu Dec  1
> 21:38:11 CET 2005     root_at_twin.gnome.no:/usr/obj/usr/src/sys/TWIN
> amd64

Did you use the 20051202b patch?  I thought I had fixed the problem,  
but I don't have an amd64 system to test on.  In any case, I'll be  
uploading up a new patch in a few minutes that removes the offending  
code entirely.

Thanks,
Jason