Re: [ports-i386_at_FreeBSD.org: tcl-8.0.5_1 failed on i386 6]

On Fri, Feb 11, 2005, Stefan Farfeleder wrote:
> On Fri, Feb 11, 2005 at 11:30:42AM -0800, Kris Kennaway wrote:
> > Can someone please take a look at why this port recently broke on 6.0?
> > 
> > Kris
> > 
> > ----- Forwarded message from User Ports-i386 <ports-i386_at_FreeBSD.org> -----
> > 
> > X-Original-To: kkenn_at_localhost
> > Delivered-To: kkenn_at_localhost.obsecurity.org
> > Delivered-To: kris_at_freebsd.org
> > Date: Fri, 11 Feb 2005 12:09:39 GMT
> > From: User Ports-i386 <ports-i386_at_FreeBSD.org>
> > To: krion_at_FreeBSD.org, kris_at_FreeBSD.org
> > Subject: tcl-8.0.5_1 failed on i386 6
> > X-UIDL: Ui-#!6#p"!_at_Gh!!DUX"!
> > X-Bogosity: No, tests=bogofilter, spamicity=0.000000, version=0.92.8
> > 
> > building tcl-8.0.5_1 on gohan10.freebsd.org
> > in directory /x/tmp/6/chroot/94908
> > maintained by: ports_at_FreeBSD.org
> > port directory: /usr/ports/lang/tcl80
> > build started at Fri Feb 11 12:07:46 UTC 2005
> > FETCH_DEPENDS=
> > PATCH_DEPENDS=
> > EXTRACT_DEPENDS=
> > BUILD_DEPENDS=
> > RUN_DEPENDS=
> > add_pkg
> > ================================================================
> > ====================<phase 1: make checksum>====================
> > ===>  Vulnerability check disabled
> > => tcl8.0.5.tar.gz doesn't seem to exist in /tmp/distfiles/.
> > => Attempting to fetch from ftp://ftp-master.freebsd.org/pub/FreeBSD/ports/distfiles/.
> > tcl8.0.5.tar.gz                                       1484 kB 2524 kBps
> > => Checksum OK for tcl8.0.5.tar.gz.
> 
> [...]
> 
> > cc -O2 -fno-strict-aliasing -pipe  -I. -I./../generic  -DHAVE_GETCWD=1 -DNO_VALUES_H=1 -DHAVE_UNISTD_H=1 -DUSE_TERMIOS=1 -DHAVE_SYS_TIME_H=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_TM_ZONE=1 -DHAVE_TM_GMTOFF=1 -DHAVE_ST_BLKSIZE=1 -DSTDC_HEADERS=1 -DNEED_MATHERR=1 -DHAVE_SIGNED_CHAR=1 -DHAVE_SYS_IOCTL_H=1 -DTCL_SHLIB_EXT=\".so\"  -DHAVE_SYS_FILIO_H=1  -DTCL_LIBRARY=\"/usr/local/lib/tcl8.0\"  -DTCL_PACKAGE_PATH="\"/usr/local/lib\""  -DNO_UNION_WAIT  -c tclMtherr.c
> > tclMtherr.c: In function `matherr':
> > tclMtherr.c:80: error: dereferencing pointer to incomplete type
> > tclMtherr.c:80: error: `DOMAIN' undeclared (first use in this function)
> > tclMtherr.c:80: error: (Each undeclared identifier is reported only once
> > tclMtherr.c:80: error: for each function it appears in.)
> > tclMtherr.c:80: error: dereferencing pointer to incomplete type
> > tclMtherr.c:80: error: `SING' undeclared (first use in this function)
> > *** Error code 1
> 
> Tcl80 needs to be built without -DNEED_MATHERR=1 (defined in
> files/Makefile.lib) on 6.0-current >= 2005-02-04.

The root of the problem is that the tcl80 port ignores the
makefiles generated by configure and thinks it knows better.
Every time something relevant to tcl changes in FreeBSD, it's
probably a good idea to re-run configure and update
files/Makefile.lib accordingly, given the current setup.
But please let me know if anything else breaks as a result of
lib/msun/src/math.h,v 1.55.

Here's a patch for the problem:

Index: Makefile.lib
===================================================================
RCS file: /home/ncvs/ports/lang/tcl80/files/Makefile.lib,v
retrieving revision 1.5
diff -u -r1.5 Makefile.lib
--- Makefile.lib	4 Aug 2003 13:21:24 -0000	1.5
+++ Makefile.lib	11 Feb 2005 22:11:11 -0000
_at__at_ -7,7 +7,7 _at__at_
 		-DHAVE_GETCWD=1 -DNO_VALUES_H=1 -DHAVE_UNISTD_H=1 -DUSE_TERMIOS=1\
 		-DHAVE_SYS_TIME_H=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_TM_ZONE=1\
 		-DHAVE_TM_GMTOFF=1 -DHAVE_ST_BLKSIZE=1 -DSTDC_HEADERS=1\
-		-DNEED_MATHERR=1 -DHAVE_SIGNED_CHAR=1 -DHAVE_SYS_IOCTL_H=1\
+		-DHAVE_SIGNED_CHAR=1 -DHAVE_SYS_IOCTL_H=1\
 		-DTCL_SHLIB_EXT=\".so\" \
 		-DHAVE_SYS_FILIO_H=1 \
 		-DTCL_LIBRARY=\"${TCL_LIBRARY}\" \