Re: UPDATE2: ATA mkIII first official patches - please test!

From: Warner Losh <imp_at_bsdimp.com>
Date: Thu, 17 Feb 2005 12:51:37 -0700 (MST)
> atadisk.ko and atapicd.ko still do not depend on atapci.ko.  So if you
> don't ask to load atapci.ko in loader.conf you will get a panic
> because the kernel won't find the root fs.  I added MODULE_DEPEND() on
> atapci macro to ata-disk.c and this solved the problem.  Perhaps this
> is just a feature.

MODULE_DEPEND should only be there when when there's a link time
dependency between modles.  If you were to add the atapci.ko as a
depend, then you destroy the ability to boot on machines that don't
have a pci bus in the kernel....

Warner
Received on Thu Feb 17 2005 - 18:52:51 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:28 UTC