Re: page fault panic in device_get_softc/acpi_pcib_route_interrupt

From: Nate Lawson <nate_at_root.org>
Date: Sat, 08 Jan 2005 10:47:51 -0800
Pawel Worach wrote:
> Nate Lawson wrote:
> 
>> [...] Change that to "acpi_get_device(handle)" and post the printout, 
>> just so I can make sure this part is working overall.
>>
> 
> Sure.
> adding child \_PR_.CPU1, dev 0xc1f7a180
> adding child \_PR_.CPU0, dev 0xc1f16e00

Ok, things are working fine (non-null devices).

> adding child \_SB_, dev 0xc1f16b80

This is not really a device and the patch I committed handles this.

> --- sys/dev/acpica/acpi_pcib.c    27 Dec 2004 05:36:47 -0000    1.53
> +++ sys/dev/acpica/acpi_pcib.c    8 Jan 2005 09:05:57 -0000
> _at__at_ -249,11 +249,18 _at__at_
>      /*
>       * We have to find the source device (PCI interrupt link device).
>       */
> -    if (ACPI_FAILURE(AcpiGetHandle(ACPI_ROOT_OBJECT, prt->Source, 
> &lnkdev))) {
> +    if (ACPI_FAILURE(AcpiGetHandle(acpi_get_handle(pcib), prt->Source,
> +    &lnkdev))) {
>      device_printf(pcib, "couldn't find PCI interrupt link device %s\n",
>          prt->Source);
>      goto out;
>      }

This change should not be committed.  I think it's correct to use \ to 
start the search since your _PRT contains relative references but the 
links are under \.

With the commit I made, you can revert all these patches, including the 
custom ASL.  It should work as before.  Let me know if it doesn't.

-- 
Nate
Received on Sat Jan 08 2005 - 17:48:12 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:25 UTC