Re: HEADS UP: Ports are not ready for CFLAGS=-O2 in 6.0

Hi Artem,

> >If we add something like this in ports/Mk/bsd.port.mk :
> >%%%
> >    .if defined(PORT_CFLAGS)
> >    CFLAGS=${PORT_CFLAGS}
> >    .end
> >%%%
> >
> >This will obviously break POLA because setting CFLAGS won't work as
> >expected.
> 
> Why not :
> .if defined(PORT_CFLAGS) && !defined(CFLAGS)
> CFLAGS=${PORT_CFLAGS}
> .endif

For me, the goal of PORT_CFLAGS is to bring the possibility to specify
_alternate_ CFLAGs when building port.  This means that PORT_CFLAGS
needs to be usable even if CFLAGS is specified.  Typically, make.conf(5)
would contain both variables.

> or even:
> .if defined(PORT_CFLAGS)
> CFLAGS=${PORT_CFLAGS} ${CFLAGS}
> .endif

The problem is mostly the same here.  If make.conf(5) contains :
%%%
	CFLAGS="-O2 -pipe -fomit-frame-pointer"
	PORT_CFLAGS="-O -pipe"
%%%

what you have written above would lead to have CFLAGS containing :
%%%
	-O -pipe -O2 -pipe -fomit-frame-pointer
%%%


However, I'm maybe misunderstanding what you said.  In this case,
correct me please.

Best regards,
-- 
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >