In message: <42D82D59.9060605_at_root.org> Nate Lawson <nate_at_root.org> writes: : Harry Coin wrote: : > At 02:28 PM 7/15/2005 -0700, Nate Lawson wrote: : > : >> Drivers should not rely on isa_get_logicalid() to determine a boolean : >> "is PNP?" : > : > : > The architecture manual specifies ISA_PNP_PROBE in non pnp ISA drivers : > for that purpose. As I understand it, John doesn't like the ugly nature : > of passing in a null device list for non-pnp ISA drivers. Hard to : > argue with that. : > : > So why not gin up a tiny little boolean kernel function : > 'device_is_pnp(dev)) ' that does the right thing for non-pnp isa drivers : > - once -,right after wherever ISA_PNP_PROBE is defined in the kernel? : : I don't understand how this is needed. ACPI devices are always a : superset of PNP. If a probe method is not PNP capable, it should never : attach to the ACPI bus. I think that's what his fix changes, and I : think it's sufficient. Nate's right here. It isn't needed. The ISA_PNP_PROBE is for all devices that have a PNP ID. Thse includes ISA PnP cards, PNP BIOS devices and ACPI devices. So the device_is_pnp() isn't needed at all. WarnerReceived on Sat Jul 16 2005 - 14:30:59 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:39 UTC