<the refs are wrong for this reply> Nate writes: > I really think the driver is broken and the API is fine for this. I > don't like the hack of returning a random CID for checks against the > HID. Drivers down the road may come to rely on this and then every BIOS > that has a different order for CIDs becomes a potential breakage point. They alredy do rely on this. When they support pnp, they call the ISA_PNP_PROBE routine. When they don't then your observation doesn't matter because the order of the IDs doesn't matter: their non-zeroness does. > Drivers should not rely on isa_get_logicalid() to determine a boolean > "is PNP?" Actually, that's the interface. We have to follow it, even if you think it is stupid. It is how we do things. When we don't have a logicalid, we return 0. When drivers don't support pnp devices, it uses the existance of a non-zero pnpid to know the device isn't for them. It has been this way since 3.0. WarnerReceived on Sat Jul 16 2005 - 17:18:59 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:39 UTC