Re: modules/acpi/acpi fails in make universe

On Sat, Jul 16, 2005 at 11:16:34AM +0200, Poul-Henning Kamp wrote:
> 
> When building i386/LINT in "make universe", the acpi/acpi module
> fails to build:
> 
> ===> acpi/acpi (depend)
> Warning: Object directory not changed from original /usr/obj/bang/src0/src/sys/L
> INT
> cc -O2 -fno-strict-aliasing -pipe  -I. -I_at_  -c /bang/src0/src/sys/i386/acpica/ac
> pi_wakecode.S
> /bang/src0/src/sys/i386/acpica/acpi_wakecode.S:35:19: assym.s: No such file or d
> irectory
> /bang/src0/src/sys/i386/acpica/acpi_wakecode.S: Assembler messages:
> /bang/src0/src/sys/i386/acpica/acpi_wakecode.S:103: Error: suffix or operands in
> valid for `ljmp'
> *** Error code 1
> 1 error
> *** Error code 2
> _at_ -> /bang/src0/src/sys
> 
> 
> Ad far as I can tell, this bit of sys/modules/acpi/acpi/Makefile
> is the offending stuff, but I can't tell what's wrong:
> 
> acpi_wakecode.h: acpi_wakecode.S assym.s
>         ${MAKE} -f ${.CURDIR}/../../../${MACHINE_ARCH}/acpica/Makefile \
>                 MAKESRCPATH=${.CURDIR}/../../../${MACHINE_ARCH}/acpica
> 
Can you reproduce this just building a LINT kernel?  I cannot, and
I fail to see how this could be a problem.  The failed "cc" command
is run from ${.CURDIR}/../../../${MACHINE_ARCH}/acpica/Makefile and
it only runs after assym.s was created.  But I have found a problem
building assym.s manually which needs fixed kmod.mk:

%%%
Index: kmod.mk
===================================================================
RCS file: /home/ncvs/src/sys/conf/kmod.mk,v
retrieving revision 1.192
diff -u -r1.192 kmod.mk
--- kmod.mk	22 Apr 2005 17:39:58 -0000	1.192
+++ kmod.mk	19 Jul 2005 10:55:55 -0000
_at__at_ -408,7 +408,10 _at__at_
 assym.s: _at_/kern/genassym.sh
 .endif
 	sh _at_/kern/genassym.sh genassym.o > ${.TARGET}
-genassym.o: _at_/${MACHINE_ARCH}/${MACHINE_ARCH}/genassym.c _at_ machine
+.if exists(_at_)
+genassym.o: _at_/${MACHINE_ARCH}/${MACHINE_ARCH}/genassym.c
+.endif
+genassym.o: _at_ machine ${SRCS:Mopt_*.h}
 	${CC} -c ${CFLAGS:N-fno-common} \
 	    _at_/${MACHINE_ARCH}/${MACHINE_ARCH}/genassym.c
 .endif
%%%

If you can reproduce the breakage, please put the complete
combined stdout+stderr output from a failed i386 LINT build
available somewhere for download.


Cheers,
-- 
Ruslan Ermilov
ru_at_FreeBSD.org
FreeBSD committer