Re: processes hanging in ufs/vfs

On Sat, 25 Jun 2005, Suleiman Souhlal wrote:

> Hi,
>
> On Jun 25, 2005, at 6:31 AM, Wesley Morgan wrote:
>
>> The strange panics I was getting last week seem to have stopped, but now I 
>> am seeing what appears to be deadlocked processes trying to read or write 
>> to the same file. The processes are, of course, unkillable and prevent a 
>> clean reboot. I was running with the "knlist_locking" patch but that no 
>> longer compiles, and backing out the recent kqueue patch doesn't work 
>> either. Traces from ddb are below.
>
> You mean it doesn't work because it does not fix the hanged processes, or 
> because you are unable to patch -R? Also, I don't understand if you see the 
> hangs with the knlist_locking patch or not..

They don't compile cleanly... Looks like some problems with macros. The 
knlist patch fails like this:

../../../kern/kern_event.c: In function `knote':
../../../kern/kern_event.c:1529: error: syntax error before "else"
../../../kern/kern_event.c: In function `knlist_add':
../../../kern/kern_event.c:1566: error: syntax error before "else"
../../../kern/kern_event.c: In function `knlist_remove_kq':
../../../kern/kern_event.c:1585: error: syntax error before "else"
../../../kern/kern_event.c: In function `knlist_mtx_lock':
../../../kern/kern_event.c:1641: warning: dereferencing `void *' pointer
../../../kern/kern_event.c:1641: error: request for member `mtx_lock' in 
something not a structure or union
../../../kern/kern_event.c: In function `knlist_mtx_unlock':
../../../kern/kern_event.c:1647: warning: dereferencing `void *' pointer
../../../kern/kern_event.c:1647: error: request for member `mtx_lock' in 
something not a structure or union
../../../kern/kern_event.c: In function `knlist_cleardel':
../../../kern/kern_event.c:1701: error: syntax error before "else"
../../../kern/kern_event.c:1696: warning: unused variable `kn'

And backing out the kqueue patch fails on a SYSINIT macro here:

../../../kern/vfs_subr.c:3331: warning: no previous prototype for 
'vop_rename_pre'
../../../kern/vfs_subr.c: In function `vop_rename_pre':
../../../kern/vfs_subr.c:3456: error: initializer element is not constant
../../../kern/vfs_subr.c:3456: error: (near initialization for 
`vfs_knlist_sys_init.func')
../../../kern/vfs_subr.c:3460: warning: no previous prototype for 
'vfs_event_signal'
../../../kern/vfs_subr.c:3465: warning: nested extern declaration of 
`filt_fsattach'
../../../kern/vfs_subr.c:3466: warning: nested extern declaration of 
`filt_fsdetach'
../../../kern/vfs_subr.c:3467: warning: nested extern declaration of 
`filt_fsevent'
../../../kern/vfs_subr.c:3520: error: initializer element is not constant
../../../kern/vfs_subr.c:3520: error: (near initialization for 
`sysctl___vfs_ctl.oid_handler')
../../../kern/vfs_subr.c:3529: warning: no previous prototype for 
'init_va_filerev'
../../../kern/vfs_subr.c:3534: error: syntax error at end of input
../../../kern/vfs_subr.c:3332: warning: unused variable `a'
../../../kern/vfs_subr.c:3469: warning: unused variable `fs_filtops'

I *think* the knlist patch was helping when I could run with it.