Re: 6.0-current panic: loading radeon module

From: John Baldwin <jhb_at_FreeBSD.org>
Date: Mon, 27 Jun 2005 16:51:52 -0400
On Sunday 26 June 2005 04:00 pm, Eric Anholt wrote:
> On Fri, 2005-06-24 at 19:59 -0400, Martin Cracauer wrote:
> > > I'd forgotten about this thread.  I've got a proposed fix for this at:
> > > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/80718
> >
> > I get the same panic and backtrace with that patch (on a 32 MB moobile
> > Radeon 7500).
> >
> > I will annotate the sourcecode now to verify (or not) the NULLs in the
> > arguments for the bus argument.
>
> OK, one more try, for everyone who's been having hangs/reboots on X
> startup since April.  Attached is a patch that will hopefully kill the
> problem off.

It would probably be best to use bus_alloc_resource() without RF_ACTIVE set as 
otherwise you'll get a base address of 0 using the bus_get_resource() method 
if the BAR hasn't been mapped yet (e.g., this isn't a boot display device).  
Also, please use 'rid = PCIR_BAR(resource)' rather than 'rid = resource * 4 + 
0x10' as that's probably a lot clearer way of saying that you are mapping BAR 
'resource'.  You can also still alloc the framebuffer resource in your last 
hunk, just don't set RF_ACTIVE for the framebuffer but do set it for the mmio 
registers.

-- 
John Baldwin <jhb_at_FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org
Received on Mon Jun 27 2005 - 18:52:05 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:37 UTC