Re: FW: pmtu patch

Qing Li wrote:
> -----Original Message-----
> From: Qing Li [mailto:qingli_at_FreeBSD.org]
> Sent: Thursday, April 28, 2005 5:36 PM
> To: andre_at_freebsd.org
> Cc: qingli_at_freebsd.org
> Subject: pmtu patch
> 
>     Hi Andre,
> 
>     I was thinking whether we could add another variable
>     in "hc_metrics" called "u_long rmx_mtu_lastupdate" and
>     perhaps a new function called "tcp_hc_getmtu_update"
> 
>     When we get the ICMP PRC_MSGSIZE notification, we do
> 
>     if (((time_second() - tcp_hc_getmtu_update(&inc)) < PMTU_MIN)
>         do_nothing;
>     else {
>       ...
>     }
> 
>     If there is no suggested mtu value, instead of immediately
>     falling back to the default, or rely on the original
>     packet fragment, can we just use the mtu value in the
>     host cache as the basis for the next try as in:
> 
>     else {
> 
>         <set new value for rmx_mtu_lastupdate>
> 
>         mtu = ip_next_mtu(tcp_hc_getmtu(&inc), 1);
> 
>     }

IMO this is too complicated for too little actual value.  It's not
that we are supposed to run into this problem all the time.  David's
idea provides a very easy way to work around the problem without
requiring any state tracking.

-- 
Andre