Re: [current tinderbox] failure on amd64/amd64

From: Bruce Evans <bde_at_zeta.org.au>
Date: Thu, 5 May 2005 20:52:39 +1000 (EST)
On Thu, 5 May 2005, Xin LI wrote:

> On Thu, May 05, 2005 at 04:44:28AM -0400, FreeBSD Tinderbox wrote:
>> /tinderbox/CURRENT/amd64/amd64/src/sys/modules/ndis/../../compat/ndis/subr_ndis.c: In function `NdisMFreeSharedMemory':
>> /tinderbox/CURRENT/amd64/amd64/src/sys/modules/ndis/../../compat/ndis/subr_ndis.c:1710: warning: long long unsigned int format, uint64_t arg (arg 3)
>
> Maybe we should make use of the PRIx64 macro?  (see patch attached)

No.  PRI* is a bug in C99; it should never be used.  Just cast the arg to
a suitable larger type with a known format (uintmax_t here).  (C99 is
missing support for better ways; either %I as in sfio (?) or %DWIM where
the compiler rewrites the string to match the arg would be better.)

Bruce
Received on Thu May 05 2005 - 08:52:46 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:34 UTC