Re: Patch to make powerd(8) devd(8)-aware

On Tue, May 17, 2005 at 10:18:35PM +0200, Fredrik Lindberg (fli+freebsd-current_at_shapeshifter.se) wrote:
> On Tue, May 17, 2005 at 07:41:44PM +0200, Poul-Henning Kamp (phk_at_phk.freebsd.dk) wrote:
> > In message <20050517163627.GA20732_at_shapeshifter.se>, Fredrik Lindberg writes:
> > >On Mon, May 16, 2005 at 10:58:20PM +0200, Poul-Henning Kamp (phk_at_phk.freebsd.dk) wrote:
> > >> In message <20050516.145207.39180036.imp_at_bsdimp.com>, Warner Losh writes:
> > >> 
> > >> >OK.  I've just committed my take on the change.  Please let me know if
> > >> >this causes you problems.
> > >> 
> > >> While you're on this:  I see powerd dying with ENOMEM about once or twice
> > >> per day...
> > >> 
> > >
> > >I'm unable to reproduce this. I've been running powerd (without the devd-patch)     
> > >all day now without any problems. As far as I can tell it does not appear to
> > >grow in size either...
> > 
> > I think it may be the sysctl failing with ENOMEM. In that case we should
> > just abandon and try again next time.
> > 
> 
> Ah, yes that's probably it. The code contains alot of err/errx calls around the
> sysctls. Once the initialization has been completed successfully it shouldn't
> choke on temporary failures. I'll try to clean this up.
> 
>    Fredrik Lindberg 

I've put together a new patch, all calls to err/errx has been changed to 
warn/warnx and put behind the verbose flag.
I also polished the devd code and made it work properly if the pipe to devd dies.

The patch is at http://shapeshifter.se/~fli/freebsd/powerd.patch
It includes all devd code so the previous patch is not needed.

   Fredrik Lindberg