Re: FW: [PATCH] MPEG2-TS patch for fwcontrol

Petr Holub wrote this message on Sat, Nov 12, 2005 at 18:51 +0100:
> do you think it would be worth commiting the following patches for
> fwcontrol to be able to receive HDV (MPEG2) streams?

I plan on looking at that in the near future once I get a -current
box together.. though if someone else wants to have a go at it,
feel free....

> -----Original Message-----
> From: Petr Holub [mailto:hopet_at_ics.muni.cz] 
> Sent: Tuesday, November 08, 2005 4:18 PM
> To: John-Mark Gurney
> Cc: multimedia_at_freebsd.org
> Subject: RE: [PATCH] MPEG2-TS patch for fwcontrol
> 
> 
> > Looks good, though you have a number of lines, both in the man page
> > and in source that are over 80 columns...  also, a quick pass after
> > reading style(9) would be good...  (variables aren't sorted properly
> > in mpegtsrecv, else not on same line as brace, spaces around if missing)..
> > you might want to update the year of the copyright :)
> 
> OK, I've tried to stylify the patches and the new version are again
> available here:
> for 5.x: http://sitola.fi.muni.cz/~hopet/HDV/fwcontrol.patch
> for 6.x: http://sitola.fi.muni.cz/~hopet/HDV/fwcontrol-6.0.patch
> 
> > Otherwise looks good... Have you looked at being able to send MPEG2-TS?
> > I wonder if it'd work w/ a DVHS deck, or a firewire capable HDTV tuner
> > like the Samsung SIR-T165...
> 
> Sending - not yet. It's a little bit more complicated process because
> of the rules for data packetization on FireWire. As for the DVHS decks,
> I don't have any so I can't try that. The functionality of the patches has
> been verified using both SONY cameras mentioned in my previous mail.

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."