Re: mount_msdosfs and longnames

Craig,

thank you for your reply. I tried your patch and build my system again. 
Now I am able to mount_msdosfs with option 'longnames', as described in 
manpage. I get no error message anymore.

Unfortunately this did not solve my main problem. As before, the FAT32 
partitions are shown only with 8.3 naming convention in small letters. 
Obviously I am not able to change it by mount options.

Do you have any other idea? Are there related changes in the files 
'msdosfs_fileno.c' and 'msdosfs_denode.c', both from 10/31/2005?

Rainer



Craig Rodrigues wrote:
> On Fri, Nov 18, 2005 at 06:50:47PM +0100, Rainer Hurling wrote:
> 
>>Looking in /usr/src/sys/fs/msdosfs/msdosfs_vfsops.c [Version 1.147 from 
>>2005/10/31 15:41:20] there is a naming discrepancy against the manpage: 
>>supported options are 'shortname' and 'longname' without s. I hope I did 
>>not misunderstood this.
> 
> 
> There was a naming discrepancy between the userland mount_msdosfs
> utility, and the implementation of the option in the
> msdos_vfsops.c for quite a while which was hidden in the mess
> of the old mount code.  When I converted mount_msdosfs to use nmount(),
> this discrepancy was uncovered.
> 
> Can you try this patch?
> 
> Index: msdosfs_vfsops.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/fs/msdosfs/msdosfs_vfsops.c,v
> retrieving revision 1.147
> diff -u -u -r1.147 msdosfs_vfsops.c
> --- msdosfs_vfsops.c	31 Oct 2005 15:41:20 -0000	1.147
> +++ msdosfs_vfsops.c	18 Nov 2005 19:02:40 -0000
> _at__at_ -81,7 +81,7 _at__at_
>  	"from",
>  	"export",
>  	"uid", "gid", "mask", "dirmask",
> -	"shortname", "longname", "win95",
> +	"shortname", "shortnames", "longname", "longnames", "win95",
>  	"kiconv", "cs_win", "cs_dos", "cs_local",
>  	NULL
>  };
> _at__at_ -163,8 +163,12 _at__at_
>  		pmp->pm_dirmask = v & ALLPERMS;
>  	vfs_flagopt(mp->mnt_optnew, "shortname",
>  	    &pmp->pm_flags, MSDOSFSMNT_SHORTNAME);
> +	vfs_flagopt(mp->mnt_optnew, "shortnames",
> +	    &pmp->pm_flags, MSDOSFSMNT_SHORTNAME);
>  	vfs_flagopt(mp->mnt_optnew, "longname",
>  	    &pmp->pm_flags, MSDOSFSMNT_LONGNAME);
> +	vfs_flagopt(mp->mnt_optnew, "longnames",
> +	    &pmp->pm_flags, MSDOSFSMNT_LONGNAME);
>  	vfs_flagopt(mp->mnt_optnew, "kiconv",
>  	    &pmp->pm_flags, MSDOSFSMNT_KICONV);