Re: [PATCH] Specifying alternative file for devd(8)

From: Joseph Koshy <joseph.koshy_at_gmail.com>
Date: Sun, 20 Nov 2005 23:13:58 +0530
wk> http://freebsd.czest.pl/dunstan/FreeBSD/diff.0.devd
wk> Comments are welcome!

Manual page comments:

-->><<--
+.It Fl f Ar file
+Use file as configuration file instead of /etc/devd.conf (default).

"Use configuration file
.Ar file
instead of the default
.Pa /etc/devd.conf ."

-->><<--

+(or alternative file specified with
+.Fl f
+flag) and uses that file to drive the rest of the process. While the
+format of this file is described in

".Fl f
option" is clearer.  Flags usually are booleans.

Sentences start on a new line.
-->><<--

diff -upr /usr/src/sbin/devd/devd.cc src/sbin/devd/devd.cc
--- /usr/src/sbin/devd/devd.cc	Mon Nov 14 03:01:10 2005
+++ src/sbin/devd/devd.cc	Sun Nov 20 18:07:08 2005

You should probably also mention in the manual page that
only one (the last) '-f' option has an effect.

The manual page also needs a .Sh FILES section that
lists /etc/devd.conf.

Otherwise the patch looks fine.
--
FreeBSD Volunteer,     http://people.freebsd.org/~jkoshy
Received on Sun Nov 20 2005 - 16:43:59 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:48 UTC