Re: Linksys EG1032 rev. 3 patch

M. Warner Losh wrote:
> In message: <4341A55B.1070209_at_shapeshifter.se>
>             Fredrik Lindberg <fli+freebsd-current_at_shapeshifter.se> writes:
> : Filtering on subvendor/subdevice might be better, I didn't even think
> : of that and revision filtering seemed to be quite popular among
> : exsisting drivers.
> 
> Yes.  Many chip vendors bump the revision field 'often'.  Just how
> often varies from chip maker to chip maker.  Some do only when they
> have a new version of the chip that needs special work arounds (or
> that no longer needs them :-).  Others do change it for each change to
> the silicon.  Most are somewhere inbetween.
> 
> : The subdevice id for a rev.3 card seems to be 0x0024 (subvendor 0x1737).
> : I don't own a rev. 2 card but google says that the rev.2 card has
> : subdevice id 0x0015 (subvendor 0x1737).
> 
> That might be sufficient...
> 
Ok, how should this be implemented then? Just a specific check in each
drivers probe methods or by adding some svid/sdid fields to
struct rl_type and similar structs.
I would go for the latter, but that might be overkill.

     Fredrik