Re: LOR #55 fix proposal (kern_descrip.c patch)

Commited.

Roman Kurakin:

> Hi,
>
>    It seems that the LOR #55 
> (http://sources.zabbadoz.net/freebsd/lor.html#055)
> could be fixed by following patch. I need testers and reviewers of it 
> since I want
> to commit it.
>
>    I do not see a reason why not to extend action of FILEDESC_LOCK.
>
> (http://www.cronyx.ru/~rik/freebsd/lor055/lor55.pch)
>
> Index: kern_descrip.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/kern/kern_descrip.c,v
> retrieving revision 1.280
> diff -u -r1.280 kern_descrip.c
> --- kern_descrip.c      26 Aug 2005 11:16:39 -0000      1.280
> +++ kern_descrip.c      27 Sep 2005 17:31:57 -0000
> _at__at_ -2275,7 +2275,6 _at__at_
>                        fdused(fdp, indx);
>                if (fp != NULL)
>                        FILE_LOCK(fp);
> -               FILEDESC_UNLOCK(fdp);
>
>                /*
>                 * We now own the reference to fp that the ofiles[] array
> _at__at_ -2283,6 +2282,9 _at__at_
>                 */
>                if (fp != NULL)
>                        fdrop_locked(fp, td);
> +
> +               FILEDESC_UNLOCK(fdp);
> +
>                return (0);
>
>        default:
>
> Best regards,
>                         rik
>
> _______________________________________________
> freebsd-hackers_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> To unsubscribe, send any mail to 
> "freebsd-hackers-unsubscribe_at_freebsd.org"