Re: panic: ifc_free_unit: bit is already cleared

From: Brooks Davis <brooks_at_one-eyed-alien.net>
Date: Tue, 11 Oct 2005 16:45:52 -0700
On Wed, Oct 12, 2005 at 12:40:14PM +1300, Andrew Thompson wrote:
> On Tue, Oct 11, 2005 at 03:07:49PM -0700, Brooks Davis wrote:
> > On Wed, Oct 12, 2005 at 10:06:02AM +1300, Andrew Thompson wrote:
> > > On Mon, Oct 10, 2005 at 01:29:00PM -0700, Brooks Davis wrote:
> > > > On Mon, Oct 10, 2005 at 03:22:08PM +1300, Andrew Thompson wrote:
> > > > > I have been testing this patch and I think it fixes all the problems
> > > > > discussed.
> > > > > 
> > > > 
> > > > I don't see any reason why you can't just replace the specific destroy
> > > > calls with calls to ifc_simple_destroy().  That would avoid expanding
> > > > the API.
> > > 
> > > I have updated the patch and yes, its a nicer way to do it. Please
> > > review.
> > > 
> > > Ive run through interations of create/kldunload with bridge, disc,
> > > faith, gif, gre and ppp with extra printf's and its freeing correctly.
> > 
> > This looks good to me, thanks for working on this and doing the
> > <ifn>_destory removals.  Let's see about getting this committed.
> > 
> 
> There was one problem where pflog0 would loop on EINVAL since it was a
> precloned device, livelocking the system.
> 
> This addition fixes it, it was either this or a dying flag.

Good catch.  I think this is an OK fix.  Did lo0 have the same issue?

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

Received on Tue Oct 11 2005 - 21:46:13 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:45 UTC