Re: ath not setting media type? [SOLVED : devd is to blame]

From: Sam Leffler <sam_at_errno.com>
Date: Wed, 19 Oct 2005 10:46:29 -0700
Niki Denev wrote:
> I think i found the problem, and it's in devd.
> 
> The problem affects only the media/link status notify events because
> there the interface name is supplied in the variable "subsystem",
> which fails to be assigned properly.
> 
> I'm not C++ expert but it looks that the duplicated declaration of the 
> variable "value" is the problem.
> I wonder why compiler doesn't complain about this... but i may be wrong,
> because i don't know anyting about c++ :)
> 
> this patch fixed it for me :
> 
> ------------------------------------------------------------------------------------------------
> --- devd.cc.orig	Wed Oct 19 19:50:28 2005
> +++ devd.cc	Wed Oct 19 19:53:29 2005
> _at__at_ -233,7 +233,7 _at__at_
>  	// to subsystem if none exists.
>  	value = c.get_variable("device-name");
>  	if (value.length() == 0)
> -		string value = c.get_variable("subsystem");
> +		value = c.get_variable("subsystem");
>  	if (Dflag)
>  		fprintf(stderr, "Testing media type of %s against 0x%x\n",
>  		    value.c_str(), _type);
> ------------------------------------------------------------------------------------------------
> 
> [http://www.totalterror.net/freebsd/devd.patch]
> 

Thank you; this'll get committed shortly.

	Sam
Received on Wed Oct 19 2005 - 15:46:51 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:45 UTC