Re: [RELENG_6] NFS panic on locking against myself

From: Xin LI <delphij_at_frontfree.net> Date: Sat, 29 Oct 2005 03:28:57 +0800 · This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:46 UTC

On Fri, Oct 28, 2005 at 10:22:49AM -0700, Mohan Srinivasan wrote:
> I saw this once too. The following change should fix this.
> 
> _at__at_ -965,7 +969,7 _at__at_
>  nfsmout:
>         if (error) {
>                 if (newvp != NULLVP) {
> -                       vrele(newvp);
> +                       vput(newvp);
>                         *vpp = NULLVP;
>                 }
>                 if ((cnp->cn_nameiop == CREATE || cnp->cn_nameiop == RENAME) &&
> 
> Will check it into current soon.

Ah!!  Thanks for this, without your confirm I was still thinking about
whether it's appropriate to replace the vrele() with vput()...

To re_at_:  Could we wait for some day to settle this change?

Cheers,
-- 
Xin LI <delphij frontfree net>	http://www.delphij.net/
See complete headers for GPG key and other information.