Re: [PATCH] Locking fixes for tl(4)

On Wed, 31 Aug 2005, John Baldwin wrote:

> Patch fixes locking for tl(4) and marks it MPSAFE.  Please test, thanks!
>
> http://www.FreeBSD.org/~jhb/patches/tl_locking.patch

Doesn't work, I'm afraid.  Panic on attach:

tl0: <Compaq Netelligent 10/100 Proliant> port 0x2800-0x280f irq 5 at 
device 7.0 on pci1


Fatal trap 12: page fault while in kernel mode
cpuid = 0; apic id = 00
fault virtual address   = 0xcc
fault code              = supervisor read, page not present
instruction pointer     = 0x20:0xc074bc7e
stack pointer           = 0x28:0xc0c20a54
frame pointer           = 0x28:0xc0c20a60
code segment            = base 0x0, limit 0xfffff, type 0x1b
                         = DPL 0, pres 1, def32 1, gran 1
processor eflags        = interrupt enabled, resume, IOPL = 0
current process         = 0 (swapper)
[thread pid 0 tid 0 ]
Stopped at      tl_mii_writereg+0xe:    cmpl    $0,0xcc(%eax)
db> tr
Tracing pid 0 tid 0 td 0xc0925e20
tl_mii_writereg(c1619000,c0c20a7c,c0c20a7c,8,c1576800) at 
tl_mii_writereg+0xe
tl_miibus_writereg(c1576800,0,0,4c00) at tl_miibus_writereg+0x39
tl_hardreset(c1576800,c1619000,1,c1576800,e11ab70) at tl_hardreset+0x32
tl_attach(c1576800) at tl_attach+0x2b6
device_attach(c1576800,e,c1576800,c1576700,c1576700) at device_attach+0x58
device_probe_and_attach(c1576800) at device_probe_and_attach+0xe0
bus_generic_attach(c1576700,c1576700,1,7c,1) at bus_generic_attach+0x16
pci_attach(c1576700) at pci_attach+0x7f
...

Note that I have not tried this machine on 7-CURRENT but without your tl 
locking patch, so it's possible that it's some other change in HEAD that 
cause this panic.  It runs happily with 6.0-BETA3.

Gavin