Re: moused related panic

On 2005-09-06 16:08, Slawa Olhovchenkov <slw_at_zxy.spb.ru> wrote:
>On Tue, Sep 06, 2005 at 04:54:19AM +0300, Giorgos Keramidas wrote:
>>On 2005-09-05 21:58, Slawa Olhovchenkov <slw_at_zxy.spb.ru> wrote:
>>>On Mon, Sep 05, 2005 at 12:27:13PM -0400, Craig Rodrigues wrote:
>>>> On Sat, Sep 03, 2005 at 04:33:44PM +0300, Giorgos Keramidas wrote:
>>>> > This was on a console running with 132x25 mode.
>>>>
>>>> Can you try this?
>>>
>>> 1. I think your remember '()' around '||'
>>> 2. Now mouse cursor not moved.
>>
>> I think I've found why this seems broken in non-graphics VESA modes.
>
> I am use non-vesa, non-graphics mode (80x30). I am not use VESA module
> and don't have option VESA in the kernel. This is diffirent case?

I'm also using a non-graphics mode (132x25) and a custom font too.  This is
the same case, as far as set_mouse_pos() is concerned, because ISGRAPHSC(scp)
is false in this case.  I'm not sure if the correct fix is the bug I posted
but at least it solved the panics for me.

I don't know why scp->font_width == 0 in text modes.  Perhaps the bug is
elsewhere, i.e. in the font changing code that should update scp->font_width
with a non-zero value.

I don't really like the "hackish" way my last patch avoids the panics, because
assuming that a default font_width of 8 is ok is probably one gratuitous
assumption too many.  I haven't had a chance to look at the font changing
implementation to see if scp->font_width can be set elsewhere to a non-zero
value or if it's supposed to be zero in text modes.

- Giorgos