Re: moused related panic

On 2005-09-06 09:32, Craig Rodrigues <rodrigc_at_crodrigues.org> wrote:
> On Tue, Sep 06, 2005 at 03:45:08PM +0300, Giorgos Keramidas wrote:
> > I don't really like the "hackish" way my last patch avoids the panics, because
> > assuming that a default font_width of 8 is ok is probably one gratuitous
> > assumption too many.  I haven't had a chance to look at the font changing
> > implementation to see if scp->font_width can be set elsewhere to a non-zero
> > value or if it's supposed to be zero in text modes.
>
> Can you try this:
>
> Index: scvidctl.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/syscons/scvidctl.c,v
> retrieving revision 1.35
> diff -u -u -r1.35 scvidctl.c
> --- scvidctl.c	30 Aug 2005 18:58:16 -0000	1.35
> +++ scvidctl.c	6 Sep 2005 13:31:30 -0000
> _at__at_ -145,6 +145,8 _at__at_
>  	return ENODEV;
>
>      /* adjust argument values */
> +    if (fontwidth <= 0)
> +	fontwidth = info.vi_cwidth;
>      if (fontsize <= 0)
>  	fontsize = info.vi_cheight;
>      if (fontsize < 14) {

This looks promising.  I'll try it out, after reverting my local patch
in a while.

Thanks :)