Re: [PATCH] AMD multicore detection

Jung-uk Kim wrote:
> New patch is here:
> http://people.freebsd.org/~jkim/multicore.diff
> 
> Please test and let me know.  I don't have multicore CPU to test it 
> for myself. :-(

The below is on a Pentium D 820 (Dualcore). I don't like that the two 
cores are reported as hyperthreading when the CPU does not support 
hyperthreading (only the 840 EE does). If we ship 6.0 with HT disabled 
I'm afraid that it will turn off one of the cores, right?

Regards,
Martin

# uname -a
FreeBSD t121.gneto.com 6.0-BETA5 FreeBSD 6.0-BETA5 #4: Thu Sep 22 
08:15:42 CEST 2005     root_at_t121.gneto.com:/usr/obj/usr/src/sys/DCORE  amd64


Before:
FreeBSD 6.0-BETA5 #3: Wed Sep 21 21:32:53 CEST 2005
     root_at_t121.gneto.com:/usr/obj/usr/src/sys/DCORE
Timecounter "i8254" frequency 1193182 Hz quality 0
CPU: Intel(R) Pentium(R) D CPU 2.80GHz (2805.62-MHz K8-class CPU)
   Origin = "GenuineIntel"  Id = 0xf44  Stepping = 4
 
Features=0xbfebfbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,C
MOV,PAT,PSE36,CLFLUSH,DTS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE>
   Features2=0x641d<SSE3,RSVD2,MON,DS_CPL,CNTX-ID,CX16,<b14>>
   AMD Features=0x20100800<SYSCALL,NX,LM>
   Hyperthreading: 2 logical CPUs
real memory  = 2137407488 (2038 MB)
avail memory = 2055442432 (1960 MB)
ACPI APIC Table: <INTEL  D945GNT >
FreeBSD/SMP: Multiprocessor System Detected: 2 CPUs
  cpu0 (BSP): APIC ID:  0
  cpu1 (AP): APIC ID:  1


After:
Copyright (c) 1992-2005 The FreeBSD Project.
Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994
         The Regents of the University of California. All rights reserved.
FreeBSD 6.0-BETA5 #4: Thu Sep 22 08:15:42 CEST 2005
     root_at_t121.gneto.com:/usr/obj/usr/src/sys/DCORE
Timecounter "i8254" frequency 1193182 Hz quality 0
CPU: Intel(R) Pentium(R) D CPU 2.80GHz (2805.61-MHz K8-class CPU)
   Origin = "GenuineIntel"  Id = 0xf44  Stepping = 4
 
Features=0xbfebfbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,C
MOV,PAT,PSE36,CLFLUSH,DTS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE>
   Features2=0x641d<SSE3,RSVD2,MON,DS_CPL,CNTX-ID,CX16,<b14>>
   AMD Features=0x20100800<SYSCALL,NX,LM>
   Hyperthreading: 2 logical CPUs
real memory  = 2137407488 (2038 MB)
avail memory = 2055438336 (1960 MB)
ACPI APIC Table: <INTEL  D945GNT >
FreeBSD/SMP: Multiprocessor System Detected: 2 CPUs
  cpu0 (BSP): APIC ID:  0
  cpu1 (AP): APIC ID:  1