AMD/Intel multicore detection (Was: Re: [PATCH] AMD multicore detection)

On Monday 26 September 2005 12:04 pm, David O'Brien wrote:
> On Wed, Sep 21, 2005 at 03:50:24PM -0400, Jung-uk Kim wrote:
> > I renewed my multicore detection patch, which was originally
> > posted here:
> >
> > http://docs.freebsd.org/cgi/mid.cgi?200505181935.18493.jkim
> > http://docs.freebsd.org/cgi/mid.cgi?200505182007.28631.jkim
> >
> > New patch is here:
> > http://people.freebsd.org/~jkim/multicore.diff
>
> I've got something I'm working on for AMD dual-core.  Please don't
> commit this.  We work just fine on AMD dual-core.  The patch to
> disable cores on Intel Hyperthreaded CPU's does not affect AMD
> dual-core in one bit.  The author nicely took the different vendors
> into account.
>
> AMD sets the CPUID.HTT simply for licensing issues - something that
> does not affect FreeBSD at all.
>
> If there is something needed for Intel dual-core CPU's with
> HyperThreading to use the real cores, but not the virtual cores -
> then by all means please commit it.

Okay.  I have a new patch here:

http://people.freebsd.org/~jkim/multicore-20050926.diff

I removed mp_machdep.c patch and added proper multicore identification 
for both AMD and Intel CPUs.  I hope this does not overlap with your 
work.  Please review/test.

> > Please test and let me know.  I don't have multicore CPU to test
> > it for myself. :-(
>
> I do and am working on something.

Please explain what you are working on, so that we don't make 
duplicate effort.

Thanks,

Jung-uk Kim