Re: CFR: ACPI Dock driver

From: Mitsuru IWASAKI <iwasaki_at_jp.FreeBSD.org>
Date: Sat, 15 Apr 2006 01:20:59 +0900 (JST)
Hi,

> --- ata-all.c   31 Mar 2006 08:09:04 -0000      1.271
> +++ ata-all.c   14 Apr 2006 15:39:20 -0000
> _at__at_ -277,8 +277,8 _at__at_
>      if (!dev || !(ch = device_get_softc(dev)))
>         return ENXIO;
> 
> -    /* wait for the channel to be IDLE before entering suspend mode */
> -    while (1) {
> +    /* wait for the channel to be IDLE or detached before suspending */
> +    while (ch->r_irq) {
>         mtx_lock(&ch->state_mtx);
>         if (ch->state == ATA_IDLE) {
>             ch->state = ATA_ACTIVE;
> 
> That I'll gladly commit for you instead...

Yes, This have also the same effect.  I prefer this.

Thanks!
Received on Fri Apr 14 2006 - 14:21:02 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:54 UTC