Re: File descriptor leak in libcam

From: Scott Long <scottl_at_samsco.org>
Date: Sat, 29 Apr 2006 17:47:53 -0600
Joe Marcus Clarke wrote:
> There is a leak in the cam_lookup_pass() if the ioctl call fails to find
> the passthru device.  Basically, the xpt file descriptor will not be
> closed.  Can anyone give me permission to commit the following patch?
> Thanks.
> 
> http://www.marcuscom.com/downloads/camlib.c.diff
> 
> Joe
> 

Looks good to me.  Style-wise, I'd have it close the fd before
testing the return of the ioctl, but that's minor.

Scott
Received on Sat Apr 29 2006 - 21:47:51 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:55 UTC