Re: is if_bridge broken?

On Sat, Aug 12, 2006 at 10:31:24AM +0300, Giorgos Keramidas wrote:
> On 2006-08-12 09:18, Christian Brueffer <brueffer_at_FreeBSD.org> wrote:
> >On Sat, Aug 12, 2006 at 09:58:08AM +0300, keramida_at_FreeBSD.org wrote:
> >> I am trying to run QEMU on a fairly recent snapshot of HEAD, but it failed with:
> >>
> >>     # DISPLAY=:0 qemu -win2k-hack -hda windows.img -boot c -net nic -net tap
> >>     bridge0: creating bridge interface
> >>     ifconfig: SIOCIFCREATE2: Invalid argument
> >>     /etc/qemu-ifup: ERROR: bridge0: failed to create
> >>     /etc/qemu-ifup: could not launch network script
> >>     Could not initialize device 'tap'
> >>     #
> >>
> >> At about the same time, `ifconfig bridge0 create' fails with:
> >>
> >> Aug 12 09:36:58 gothmog kernel: KLD if_bridge.ko: depends on bridgestp - not available
> >> Aug 12 09:36:58 gothmog giorgos: /etc/qemu-ifup: ERROR: bridge0: failed to create
> >>
> > Have you tried loading the bridgestp module as suggested?  Is has been
> > split out of if_bridge recently and exists in my CURRENT system.
> 
> Yes :-(
> 
> It doesn't make a lot of difference:
> 

It seems I forgot the module version, this should hopefully fix it.


Index: bridgestp.c
===================================================================
RCS file: /home/ncvs/src/sys/net/bridgestp.c,v
retrieving revision 1.18
diff -u -p -r1.18 bridgestp.c
--- bridgestp.c 2 Aug 2006 02:51:42 -0000       1.18
+++ bridgestp.c 12 Aug 2006 10:06:58 -0000
_at__at_ -929,6 +929,7 _at__at_ static moduledata_t bstp_mod = {
 };
 
 DECLARE_MODULE(bridgestp, bstp_mod, SI_SUB_PSEUDO, SI_ORDER_ANY);
+MODULE_VERSION(bridgestp, 1);
 
 void
 bstp_attach(struct bstp_state *bs, bstp_state_cb_t state_callback)