Re: Slight interface change on the watchdog fido

From: Nick Hibma <nick_at_van-laarhoven.org>
Date: Tue, 12 Dec 2006 08:49:53 +0100 (CET)
> It would be nice to not lose the comments.  Might also be nice to reduce the
> diff (so it doesn't have to reindent everything) by just adding a simple test
> after masking off WD_INTERVAL like so:
>
> 	if (cmd == 0 || cmd >= 64) {
> 		ipmi_set_watchdog(sc, 0);
> 		return;
> 	}

The code path pretty much requires the

 	if (cmd > 0 && valid(cmd) {
 		wd(set);
 		*error = 0;
 	} else if (wd(active)) {
 		wd(disable);
 	}

due to the way *error was defined.

I've added back the comments that were more than trivial.

Nick
Received on Tue Dec 12 2006 - 06:50:21 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:03 UTC